Added transaction support for saveAll in JdbcChatMemoryRepository #3158
Conversation
Signed-off-by: Sun Yuhan <[email protected]>
...c/main/java/org/springframework/ai/chat/memory/repository/jdbc/JdbcChatMemoryRepository.java
Outdated
Show resolved
Hide resolved
…pository. Signed-off-by: Sun Yuhan <[email protected]>
…pository. Signed-off-by: Sun Yuhan <[email protected]>
...c/main/java/org/springframework/ai/chat/memory/repository/jdbc/JdbcChatMemoryRepository.java
Outdated
Show resolved
Hide resolved
…pository. Signed-off-by: Sun Yuhan <[email protected]>
Signed-off-by: Sun Yuhan <[email protected]>
|
This approach won't enable participation in a surrounding outer scope transaction, I'll work on a solution. |
Indeed, but do we really need participating in outer scope transaction here? |
You're right; this approach indeed cannot participate in outer scope transaction. However, it seems that ChatMemoryRepository is inherently designed with ChatMemory in mind. In such a scenario, do we really have an "outer scope transaction" that needs to be involved? |
|
Who knows what people will do in the wild, it is a tiny change to the PR. |
|
Thanks @sunyuhan1998 merged in 0e1bb52 |
3 participants
In the saveAll method of JdbcChatMemoryRepository, all historical messages of the current conversation are first deleted, and then the latest list of messages is saved. This operation should be transactional. This PR adds transaction support for it.